feat(ui): #2051: TransactionSummary
#2083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit db3536d): https://penumbra-ui-preview--pr2083-feat-2051-tx-summar-rkethfkg.web.app (expires Fri, 07 Mar 2025 08:22:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
VanishMax
commented
Feb 28, 2025
| /** | ||
| * Takes a transaction view, finds the most relevant action that defines its type, and returns it. | ||
| */ | ||
| export const classifyTransaction = (txv?: TransactionView): ClassificationReturn => { |
There was a problem hiding this comment.
a powerful function, it was returning only a classified type of a transaction. I added the return of the most relevant action type given transaction
| export interface AddressViewProps { | ||
| addressView: AddressView | undefined; | ||
| copyable?: boolean; | ||
| hideIcon?: boolean; | ||
| truncate?: boolean; | ||
| /** If true, takes the `altBech32m` field from the address and renders it as-is */ | ||
| external?: boolean; |
There was a problem hiding this comment.
added support for AddressView component to render addresses from other blockchains like osmo1awefasdf...
Comment on lines
+63
to
+66
| export const useClassification = ( | ||
| info: TransactionInfo, | ||
| getMetadataByAssetId?: GetMetadataByAssetId, | ||
| ) => { |
There was a problem hiding this comment.
the main data modeling logic is here - the hook prepares a transaction for rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2051
An independent PR but only #2000 will allow applying this component to the DEX or other products.
Preview of the component: https://penumbra-ui-preview--pr2083-feat-2051-tx-summar-rkethfkg.web.app/?path=/docs/ui-library-transactionsummary--docs
Needs a follow up work to support the whole range of transaction types but I'd like to switch to other features. At least this component works well on Send/Receive/Swap transaction types and partially on the rest of them.