feat(ui): #2053: ActionView component part 3 #2069
Conversation
…ws-3 # Conflicts: # packages/ui/src/ActionView/action-view.tsx # packages/ui/src/ActionView/actions/swap-claim.tsx # packages/ui/src/ActionView/index.stories.tsx # packages/ui/src/ActionView/swap/swap.tsx # packages/ui/src/ActionView/types.ts # packages/ui/src/utils/bufs/action-view.ts
|
Visit the preview URL for this PR (updated for commit 424bf83): https://penumbra-ui-preview--pr2069-feat-2053-action-vi-95umkza1.web.app (expires Mon, 03 Mar 2025 17:19:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
|
@TalDerei as per new requirements, position actions should render the reserves, fees, and the position id. Forgot to show fees in Storybook but it's implemented. As for positionId, it's an open question about how to compute it in TypeScript without calling wasm functions |
There was a problem hiding this comment.
thanks for the clarification – per the new requirements, this looks good to me! for now, let's display the fees in the storybook and consider using the ownedPositionIds view service method to render the relevant positionId? We can iterate on it as needed.
also, missing changeset
Continuation of #2053
In this PR:
AssetIconcomponent v2 design – added support forbadgefield representing asset networkAssetGroupUIv2 componentPositionOpenPositionClosePositionWithdrawPositionRewardClaimPositionOpen now displays asset Metadata and shows correct amount exponents for reserves in comparison with old ActionViews. The rest of the views only display positionId due to lack of data in protobufs. Should we modify them to return full Position?