Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into feat/#2053-action-vie…
Browse files Browse the repository at this point in the history
…ws-3
  • Loading branch information
VanishMax committed Feb 24, 2025
2 parents 9db92b9 + ef2f215 commit fbfd72a
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ https://excalidraw.com/#json=_3b4K0RpWFJWAtVCH5ymB,CHegLkto1X_NdKG67LNh2A
### Some critical details

Prax and Minifront [share React components](./ui-library.md) and some other
reuseable dependencies.
reusable dependencies.

Both Prax and Minifront manage running state with Zustand. For storage, Prax
uses extension storage and idb. Minifront does not store anything.
Expand Down
4 changes: 2 additions & 2 deletions docs/adrs/004-privacy-invariants.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ Generally, the local and session storage need to be more restricted.
```
Invariant 2.
The Content Security Policy (CSP) defined in the Manifest V3 file must restrict permissions to only those that are necessary, ensuring no extranous security risks are introduced.
The Content Security Policy (CSP) defined in the Manifest V3 file must restrict permissions to only those that are necessary, ensuring no extraneous security risks are introduced.
```

Currently, we define `wasm-unsafe-eval` in the manifest file to enable dynamic loading of WebAssembly modules. Without the `wasm-unsafe-eval` CSP directive, WebAssembly is blocked from loading and executing on the page. However, `wasm-unsafe-eval` opens up the possiblity for attackers to inject and execute malicious WebAssembly code:
Currently, we define `wasm-unsafe-eval` in the manifest file to enable dynamic loading of WebAssembly modules. Without the `wasm-unsafe-eval` CSP directive, WebAssembly is blocked from loading and executing on the page. However, `wasm-unsafe-eval` opens up the possibility for attackers to inject and execute malicious WebAssembly code:

```
const maliciousCode = "(wasm binary code)";
Expand Down
2 changes: 1 addition & 1 deletion docs/extension-services.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Service Implementation

Services in this repository should eventually be re-useable, but you can also
Services in this repository should eventually be reusable, but you can also
implement your own services. Implementation is much like developing a web
service, using the normal ConnectRPC server-side metaphors and types.

Expand Down
2 changes: 1 addition & 1 deletion docs/guiding-principles.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ code quality high. See [CI/CD guide](ci-cd.md) for running commands locally.

## Modularity from the beginning

We should attempt to be liberal about adding packages if we think it can get re-use from another
We should attempt to be liberal about adding packages if we think it can get reuse from another
app in this repo or even outside. This will allow us to expose critical functionality
that can make developing further apps easier.

Expand Down
8 changes: 8 additions & 0 deletions packages/wasm/crate/rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[toolchain]
# We set a specific version of rust so that CI workflows use the same
# version development environments do.
channel = "1.83"
components = [ "rustfmt", "rust-analyzer" ]
# Include wasm toolchain, for CI tests to check wasm32 build targets still work,
# to avoid downstream breakage in `penumbra-wasm` crate, in the web repo.
targets = [ "wasm32-unknown-unknown" ]

0 comments on commit fbfd72a

Please sign in to comment.