feat(pindexer): optional exit-on-catchup #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
commented
Feb 20, 2025
| return Ok(()); | ||
| if exit_on_catchup { | ||
| tracing::info!("catchup completed, exiting as requested"); | ||
| std::process::exit(0); |
There was a problem hiding this comment.
It's a bit of a hack to std::process::exit() here. Perhaps we should instead return a custom Result::CatchUp that triggers an exit in the main loop? Didn't seem worthwhile for a quick feature add, but open to suggestions.
There was a problem hiding this comment.
I wrote up a quick commit to avoid std::process::exit: #5103 ; I think I'd like to see that included in this PR (or something equivalent). Result<bool> seems fine enough to capture the possibilities there, and avoids the woes of direct exits, in case we want to run this code in a different context.
This was referenced Feb 21, 2025
For running batch jobs managing indexing pipelines, it'd be convenient to instruct pindexer to exit after it's finished processing the events that's available to it. This situation arises frequently in batch processing, where pindexer will be pointed at a source db that was restored from a db. Having pindexer exit 0 on success, else non-zero on error, will aid in building out test infrastructure.
conorsch
force-pushed
the
pindexer-exit-on-catchup
branch
from
d6e91a1 to
b530dfc
Compare
some suggested changes to #5101
|
Thanks @cronokirby, that change is just what I was looking for! |
cronokirby
approved these changes
Feb 21, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
For running batch jobs managing indexing pipelines, it'd be convenient to instruct pindexer to exit after it's finished processing the events that's available to it. This situation arises frequently in batch processing, where pindexer will be pointed at a source db that was restored from a db. Having pindexer exit 0 on success, else non-zero on error, will aid in building out test infrastructure.
Issue ticket number and link
N/A
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: