pd: add no-op migration for APP_VERSION 10 #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The no-op migration is necessary but not yet sufficient: I am indeed encountering the version mismatch logic anticipated in #5073 (comment). Working with a pre-upgrade backup of node state to test changes, will append a patch here and mark RFR when done. |
Follow-up to #5073, which should have included a no-op migration.
conorsch
force-pushed
the
fix-lqt-version-recognition
branch
from
b254713 to
1e7537e
Compare
In the first draft of this PR, I'd neglected to update the default migration used by |
conorsch
added
the
consensus-breaking
cronokirby
approved these changes
Feb 7, 2025
conorsch
added a commit
that referenced
this pull request
Feb 14, 2025
## Describe your changes Follow-up to #5073, which should have included a no-op migration. ## Issue ticket number and link Towards #5010. ## Testing and review This work will be used to perform a chain upgrade on the PL testnet. Once that's done, we should expect CI to pass fully on this PR, in particular the "testnet-integration" suite. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > provides migration logic for proposed protocol-breaking changes
conorsch
added a commit
that referenced
this pull request
Feb 21, 2025
## Describe your changes Follow-up to #5073, which should have included a no-op migration. ## Issue ticket number and link Towards #5010. ## Testing and review This work will be used to perform a chain upgrade on the PL testnet. Once that's done, we should expect CI to pass fully on this PR, in particular the "testnet-integration" suite. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > provides migration logic for proposed protocol-breaking changes
cronokirby
pushed a commit
that referenced
this pull request
Feb 27, 2025
## Describe your changes Follow-up to #5073, which should have included a no-op migration. ## Issue ticket number and link Towards #5010. ## Testing and review This work will be used to perform a chain upgrade on the PL testnet. Once that's done, we should expect CI to pass fully on this PR, in particular the "testnet-integration" suite. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > provides migration logic for proposed protocol-breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow-up to #5073, which should have included a no-op migration.
Issue ticket number and link
Towards #5010.
Testing and review
This work will be used to perform a chain upgrade on the PL testnet. Once that's done, we should expect CI to pass fully on this PR, in particular the "testnet-integration" suite.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: