pcli: support multiple lp withdrawals #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
reviewed
Feb 6, 2025
| @@ -747,7 +747,7 @@ impl ViewService for ViewServer { | |||
| tonic::Status::invalid_argument(format!("Could not parse pair: {e:#}")) | |||
| })?; | |||
|
|
|||
| planner.position_withdraw(position_id, reserves, trading_pair); | |||
| planner.position_withdraw(position_id, reserves, trading_pair, 0); | |||
There was a problem hiding this comment.
Why is this being 0 ok? Wouldn't we want to follow the planning request?
There was a problem hiding this comment.
This is kind of a fake TPR implementation, unlike the one in Prax. It's not used by the regular pcli commands, I think an integration test uses it maybe. Making it work here is possible but low ROI, so I opted for not doing anything
There was a problem hiding this comment.
Sounds good ; we could maybe add a comment to that effect
conorsch
force-pushed
the
protocol/lqt_branch
branch
from
466394b to
ae2300b
Compare
cronokirby
force-pushed
the
erwan/pcli_multi_withdraw
branch
from
3b003fa to
595789f
Compare
|
We're not currently exercising the multiple-withdraw behavior in the integration tests, but we'll be exercising these code paths a lot toward LQT support (#5010). |
conorsch
approved these changes
Feb 21, 2025
conorsch
pushed a commit
that referenced
this pull request
Feb 21, 2025
## Describe your changes Now we can use `pcli tx withdraw <id>` to withdraw a position multiple times, increasing its sequence. We fetch the reserves on every try so that the balance commitment is always accurate. To view the output, use `pcli v balance --by-note` this is unfortunate but wontfix now. ## Issue ticket number and link #5069 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) --------- Co-authored-by: Lucas Meier <[email protected]>
cronokirby
added a commit
that referenced
this pull request
Feb 27, 2025
## Describe your changes Now we can use `pcli tx withdraw <id>` to withdraw a position multiple times, increasing its sequence. We fetch the reserves on every try so that the balance commitment is always accurate. To view the output, use `pcli v balance --by-note` this is unfortunate but wontfix now. ## Issue ticket number and link #5069 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) --------- Co-authored-by: Lucas Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now we can use
pcli tx withdraw <id>to withdraw a position multiple times, increasing its sequence. We fetch the reserves on every try so that the balance commitment is always accurate.To view the output, use
pcli v balance --by-notethis is unfortunate but wontfix now.Issue ticket number and link
#5069
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: