feat: add summary to TransactionInfo (#5102)

Adds a `summary` field of type `TransactionSummary` to `TransactionInfo`
proto.

Mostly needed for Web because Rust ecosystem can simply do
`tx_info.view.summary()` but Web would have to re-implement this feature
in TypeScript

crates/bin/pcli/src/command/view/tx.rs

@@ -49,13 +49,15 @@ impl TxCmd {
             let tx = Transaction::decode(rsp.tx.as_slice())?;
             let txp = Default::default();
             let txv = tx.view_from_perspective(&txp);
+            let summary = txv.summary();
 
             TransactionInfo {
                 height: rsp.height,
                 id: hash,
                 transaction: tx,
                 perspective: txp,
                 view: txv,
+                summary: summary,
             }
         };
 

crates/core/transaction/src/lib.rs

@@ -41,7 +41,7 @@ pub use is_action::IsAction;
 pub use parameters::TransactionParameters;
 pub use penumbra_sdk_txhash as txhash;
 pub use plan::{ActionPlan, TransactionPlan};
-pub use transaction::{Transaction, TransactionBody};
+pub use transaction::{Transaction, TransactionBody, TransactionSummary};
 pub use view::{ActionView, MemoPlaintextView, MemoView, TransactionPerspective, TransactionView};
 pub use witness_data::WitnessData;
 

crates/proto/src/gen/penumbra.view.v1.rs

@@ -1478,6 +1478,11 @@ pub struct TransactionInfo {
     pub view: ::core::option::Option<
         super::super::core::transaction::v1::TransactionView,
     >,
+    /// A short view of balances leaving and entering accounts, computed from transaction actions.
+    #[prost(message, optional, tag = "6")]
+    pub summary: ::core::option::Option<
+        super::super::core::transaction::v1::TransactionSummary,
+    >,
 }
 impl ::prost::Name for TransactionInfo {
     const NAME: &'static str = "TransactionInfo";

crates/proto/src/gen/penumbra.view.v1.serde.rs

@@ -5870,6 +5870,9 @@ impl serde::Serialize for TransactionInfo {
         if self.view.is_some() {
             len += 1;
         }
+        if self.summary.is_some() {
+            len += 1;
+        }
         let mut struct_ser = serializer.serialize_struct("penumbra.view.v1.TransactionInfo", len)?;
         if self.height != 0 {
             #[allow(clippy::needless_borrow)]
@@ -5888,6 +5891,9 @@ impl serde::Serialize for TransactionInfo {
         if let Some(v) = self.view.as_ref() {
             struct_ser.serialize_field("view", v)?;
         }
+        if let Some(v) = self.summary.as_ref() {
+            struct_ser.serialize_field("summary", v)?;
+        }
         struct_ser.end()
     }
 }
@@ -5903,6 +5909,7 @@ impl<'de> serde::Deserialize<'de> for TransactionInfo {
             "transaction",
             "perspective",
             "view",
+            "summary",
         ];
 
         #[allow(clippy::enum_variant_names)]
@@ -5912,6 +5919,7 @@ impl<'de> serde::Deserialize<'de> for TransactionInfo {
             Transaction,
             Perspective,
             View,
+            Summary,
             __SkipField__,
         }
         impl<'de> serde::Deserialize<'de> for GeneratedField {
@@ -5939,6 +5947,7 @@ impl<'de> serde::Deserialize<'de> for TransactionInfo {
                             "transaction" => Ok(GeneratedField::Transaction),
                             "perspective" => Ok(GeneratedField::Perspective),
                             "view" => Ok(GeneratedField::View),
+                            "summary" => Ok(GeneratedField::Summary),
                             _ => Ok(GeneratedField::__SkipField__),
                         }
                     }
@@ -5963,6 +5972,7 @@ impl<'de> serde::Deserialize<'de> for TransactionInfo {
                 let mut transaction__ = None;
                 let mut perspective__ = None;
                 let mut view__ = None;
+                let mut summary__ = None;
                 while let Some(k) = map_.next_key()? {
                     match k {
                         GeneratedField::Height => {
@@ -5997,6 +6007,12 @@ impl<'de> serde::Deserialize<'de> for TransactionInfo {
                             }
                             view__ = map_.next_value()?;
                         }
+                        GeneratedField::Summary => {
+                            if summary__.is_some() {
+                                return Err(serde::de::Error::duplicate_field("summary"));
+                            }
+                            summary__ = map_.next_value()?;
+                        }
                         GeneratedField::__SkipField__ => {
                             let _ = map_.next_value::<serde::de::IgnoredAny>()?;
                         }
@@ -6008,6 +6024,7 @@ impl<'de> serde::Deserialize<'de> for TransactionInfo {
                     transaction: transaction__,
                     perspective: perspective__,
                     view: view__,
+                    summary: summary__,
                 })
             }
         }

crates/view/src/client.rs

@@ -769,6 +769,10 @@ where
                     .view
                     .ok_or_else(|| anyhow::anyhow!("missing view"))?
                     .try_into()?,
+                summary: rsp
+                    .summary
+                    .ok_or_else(|| anyhow::anyhow!("missing summary"))?
+                    .try_into()?,
             };
 
             Ok(tx_info)
@@ -826,6 +830,10 @@ where
                             .view
                             .ok_or_else(|| anyhow::anyhow!("missing view"))?
                             .try_into()?,
+                        summary: tx_rsp
+                            .summary
+                            .ok_or_else(|| anyhow::anyhow!("missing summary"))?
+                            .try_into()?,
                     };
 
                     Ok(tx_info)

crates/view/src/service.rs

@@ -1059,6 +1059,7 @@ impl ViewService for ViewServer {
 
         // Finally, compute the full TxV from the full TxP:
         let txv = tx.view_from_perspective(&txp);
+        let summary = txv.summary();
 
         let response = pb::TransactionInfoByHashResponse {
             tx_info: Some(pb::TransactionInfo {
@@ -1067,6 +1068,7 @@ impl ViewService for ViewServer {
                 perspective: Some(txp.into()),
                 transaction: Some(tx.into()),
                 view: Some(txv.into()),
+                summary: Some(summary.into()),
             }),
         };
 

crates/view/src/transaction_info.rs

@@ -1,5 +1,5 @@
 use penumbra_sdk_transaction::{
-    txhash::TransactionId, Transaction, TransactionPerspective, TransactionView,
+    txhash::TransactionId, Transaction, TransactionPerspective, TransactionSummary, TransactionView,
 };
 
 #[derive(Debug, Clone)]
@@ -14,4 +14,6 @@ pub struct TransactionInfo {
     pub perspective: TransactionPerspective,
     // A precomputed transaction view of `transaction` from `perspective`, included for convenience of clients that don't have support for viewing transactions on their own.
     pub view: TransactionView,
+    // A short view of balances leaving and entering accounts, computed from transaction actions.
+    pub summary: TransactionSummary,
 }

proto/penumbra/penumbra/view/v1/view.proto

@@ -646,6 +646,8 @@ message TransactionInfo {
   core.transaction.v1.TransactionPerspective perspective = 4;
   // A precomputed transaction view of `transaction` from `perspective`, included for convenience of clients that don't have support for viewing transactions on their own.
   core.transaction.v1.TransactionView view = 5;
+  // A short view of balances leaving and entering accounts, computed from transaction actions.
+  core.transaction.v1.TransactionSummary summary = 6;
 }
 
 message TransactionInfoResponse {