Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description of DEX #53

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

redshiftzero
Copy link
Collaborator

@redshiftzero redshiftzero commented Feb 13, 2025

Adds a description of the DEX
Also moves up the liquidity provisioning section in the sidebar

Comments welcome!

@redshiftzero redshiftzero changed the title wip: fill in DEX description add description of DEX Feb 17, 2025
@redshiftzero redshiftzero marked this pull request as ready for review February 17, 2025 17:23
@TalDerei
Copy link

happy to review this and #55, just ping me for review!

@redshiftzero
Copy link
Collaborator Author

thanks @TalDerei - both this and #55 are ready for review!

@TalDerei TalDerei self-requested a review February 18, 2025 02:24
Copy link

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good to me, left some feedback 👍

I think at some point @smmhrdmn may want to redesign some of the graphics across the guide (?), and these serve as good references for shaping the information that will be embedded in those designs.

@smmhrdmn
Copy link

content looks good to me, left some feedback 👍

I think at some point @smmhrdmn may want to redesign some of the graphics across the guide (?), and these serve as good references for shaping the information that will be embedded in those designs.

totally! this would have ideally been a part of the guide redesign but we never got there. these are great additions, and as you say we'll now have a better reference to go off of

@redshiftzero
Copy link
Collaborator Author

thanks for review @TalDerei! made some changes

@TalDerei
Copy link

thanks for review @TalDerei! made some changes

LGTM!

@redshiftzero
Copy link
Collaborator Author

heads up I don't have merge access in this repo

@TalDerei
Copy link

heads up I don't have merge access in this repo

cc @conorsch

@conorsch
Copy link
Contributor

heads up I don't have merge access in this repo

You do now! Have at it!

@redshiftzero redshiftzero merged commit 84d89dd into penumbra-zone:main Feb 20, 2025
1 check passed
@redshiftzero redshiftzero deleted the guide-update-dex-page branch February 20, 2025 18:13
@redshiftzero redshiftzero mentioned this pull request Feb 24, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants