feat: filter positions by subaccount #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
|
I’d like to perform additional assurance checks on this in relation to prax-wallet/prax#279 since the prax PR is a sensitive changeset to the block processor component. |
TalDerei
approved these changes
Jan 29, 2025
# Conflicts: # src/pages/trade/ui/positions/index.tsx
VanishMax
force-pushed
the
feat/filter-positions-by-subaccount
branch
from
1005f7f to
133016c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters positions by subaccount.
Closes #239
Relates to penumbra-zone/web#1989
The main work is in penumbra-zone/web#2006 (Web) and prax-wallet/prax#279 (Prax)
This PR must wait for the Web PR to be merged to apply the latest
protobufversion