Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saml): extracting key data points issue #3570 #3572

Closed
wants to merge 1 commit into from
Closed

fix(saml): extracting key data points issue #3570 #3572

wants to merge 1 commit into from

Conversation

brianray
Copy link

@brianray brianray commented Dec 19, 2023

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

@pennersr
Copy link
Owner

We really need to extend the test suite for this case. Can you look into that, or, send me one of your SAML payloads so that I can introspect/extend it myself?

@coveralls
Copy link

Coverage Status

coverage: 95.859% (-0.005%) from 95.864%
when pulling f928ceb on brianray:main
into 32c9eaf on pennersr:main.

@pennersr
Copy link
Owner

Fixed via 6251d5e

@pennersr pennersr closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants