Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature custom forms mfa #3560

Closed
wants to merge 4 commits into from
Closed

Feature custom forms mfa #3560

wants to merge 4 commits into from

Conversation

nikvaro
Copy link

@nikvaro nikvaro commented Dec 11, 2023 •
edited
Loading

#3555

Submitting Pull Requests

General

  • [x ] Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • [ x] All Python code must formatted using Black, and clean from pep8 and isort issues.

pennersr
pennersr requested changes Dec 11, 2023
View reviewed changes
@nikvaro nikvaro requested a review from pennersr December 12, 2023 11:04
@coveralls
Copy link

Coverage Status

coverage: 95.855% (+0.03%) from 95.825%
when pulling 5f089a3 on nikvaro:feature-custom-forms-mfa
into 4b5e376 on pennersr:main.

pennersr
pennersr requested changes Dec 12, 2023
View reviewed changes
Copy link
Owner

@pennersr pennersr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some conflicts, other than that this is looking good.

@pennersr
Copy link
Owner

Merged via 62dd283

@pennersr pennersr closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennersr pennersr pennersr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikvaro @coveralls @pennersr