Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): Add Vietnamese translations #3559

Closed
wants to merge 1 commit into from

Conversation

vodquang96
Copy link

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

#: account/forms.py:491
#, python-format
msgid "You cannot add more than %d email addresses."
msgstr ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a quite some translations that are still to go. Can you look into those?

Copy link
Author

@vodquang96 vodquang96 Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the plan. Not sure if I have time for that now. Do you mind keeping this pr here until I'm done?

@coveralls
Copy link

coveralls commented Dec 10, 2023

Coverage Status

coverage: 95.796%. remained the same
when pulling bd536ed on vodquang96:add-vi-locale
into b0ae821 on pennersr:main.

@pennersr pennersr marked this pull request as draft December 15, 2023 22:35
@pennersr pennersr closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants