Skip to content

Fix buffer underflow when serial peer spews garbage #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix buffer underflow when serial peer spews garbage #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ char *answerback;

static void write_receive_buf(const unsigned char *buf, int len)
{
if (!len)
if (len <= 0)
return;

write(STDOUT_FILENO, buf, len);
Expand Down Expand Up @@ -306,7 +306,7 @@ static int handle_receive_buf(struct ios_ops *ios, unsigned char *buf, int len)
unsigned char *sendbuf = buf;
int i;

while (len) {
while (len > 0) {
switch (*buf) {
case IAC:
/* BUG: this is telnet specific */
Expand Down