Some chapter 1 grammar/flow suggestions #105
Open
+118
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily minor grammar fixes, but a few suggestions included for sentences I found confusing.
|
I assign the copyright of this contribution to Pedro Duarte Faria |
|
Thank you @burlingsmith for your contribution! I will take a look at it 😉 |
pedropark99
reviewed
Jan 31, 2025
| This phrase is specially true for C++ programmers. Because C++ is a gigantic language, | ||
| with tons of features, and also, there are lots of different "flavors of C++". These elements | ||
| are what makes C++ so complex and hard to learn. Zig tries to go in the opposite direction. | ||
| This phrase is especially true for C++ programmers because C++ is a gigantic language, |
There was a problem hiding this comment.
I prefer to end the phrase in the "programmers" with the final dot. It feels a better reading flow to me.
Suggested change
| This phrase is especially true for C++ programmers because C++ is a gigantic language, | |
| This phrase is especially true for C++ programmers. Because C++ is a gigantic language, | |
| your C code. With macros, you are no longer 100% sure about which pieces | ||
| of the code are being sent to the compiler, i.e. | ||
| they obscures the actual source code that you wrote. | ||
| The phrase above is still important for C programmers too because, even with C being a simple |
There was a problem hiding this comment.
Once again, ending the phrase with the dot, gives me a better reading flow here. Although you did some nice changes in this paragraph.
Suggested change
| The phrase above is still important for C programmers too because, even with C being a simple | |
| The phrase above is still important for C programmers too. Because, even with C being a simple | |
| You also don't have a hidden control flow happening behind the scenes. And, you also | ||
| don't have functions or operators from the standard library that make | ||
| hidden memory allocations behind your back. | ||
|
|
||
| By being a simpler language, Zig becomes much more clear and easier to read/write, | ||
| but at the same time, it also achieves a much more robust state, with more consistent | ||
| By being a simpler language, Zig becomes much clearer and easier to read and write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some grammar or flow fixes I noted down while starting to read the book. Primarily minor grammar fixes, but a few suggested changes to sentences I found confusing.
Please let me know if you have any questions or if this is not the sort of contribution you are looking for. Thank you!