Fix for Docker with instructions in readme #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorixelle
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Looks good, thanks for the fixes! I've split out the PRs for you, just need to fix the commit lints and we're good to merge.
Sorixelle
added
type: bug
|
I am banging my head against the wall. I fixed the lint and it added back in the other commits that you removed. |
|
I f**king fixed it! I finally figured out how to get rid of the other commits from this branch! It has taken me hours to understand this stuff! I am hoping that I am finally starting to understand rebase. |
saltedlolly
changed the title
|
Same as the other PR, just needs the signoffs. |
Signed-off-by: Olly Stedall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can only apologise. In trying to separate the Docker changes into a separate PR I managed to accidentally add it to the other PR by mistake. Then in trying to fix it, I managed to make it worse. This PR is simply to fix the readme even though it includes other previous commits.