-
Notifications
You must be signed in to change notification settings - Fork 6
Update hardware information to include new Core Devices watches #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm going to hold off reviewing this one for now - Core Devices has some documentation they want to contribute here, so I'll check to see if this is a part of that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't in Core's changes, so I've given this one a review.
I tried so hard to split the "fixes for docker" commit into a separate branch so i could make a separate PR, and somehow they still ended up in this one. 🤬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, got the docker changes out of here. Looks good now, thanks for the contribution! Just fix up the commit lints in this run and we should be good to merge.
Would you mind if I DM you on Discord? I spent hours trying to figure out how to split the commits into differnent PRs, and I would really like to understand how to do it. My knowledge of basic Github stuff has been okay for years, but I am not a professional developer, only a hobbyist, and struggle to understand the more advanced stuff. I spent ages on over |
Ok well this has been a learning experience. Finally unscrambled. |
Ther lint error appears to be about the comment above being too long? I have no idea what that is about. Does that make sense to you? Commit bdcd15d: Update: I edited the comment to make it shorter. Let's see if it accepts it now. |
Commit length is good, but still need the Signed-off-by lines - see the contribution guides |
Signed-off-by: Olly Stedall <[email protected]>
Signed-off-by: Olly Stedall <[email protected]>
Some of the information is incomplete at this stage, since it is still not confirmed.