Skip to content

Update hardware information to include new Core Devices watches #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

saltedlolly
Copy link

@saltedlolly saltedlolly commented Aug 4, 2025

Some of the information is incomplete at this stage, since it is still not confirmed.

@Sorixelle Sorixelle added the area: content Changes to files that include developer documentation content label Aug 5, 2025
@Sorixelle
Copy link
Member

I'm going to hold off reviewing this one for now - Core Devices has some documentation they want to contribute here, so I'll check to see if this is a part of that.

Copy link
Member

@Sorixelle Sorixelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't in Core's changes, so I've given this one a review.

@saltedlolly saltedlolly requested a review from Sorixelle August 11, 2025 11:43
@saltedlolly
Copy link
Author

I tried so hard to split the "fixes for docker" commit into a separate branch so i could make a separate PR, and somehow they still ended up in this one. 🤬

@saltedlolly
Copy link
Author

Screenshot 2025-08-11 at 10 13 06 pm

Copy link
Member

@Sorixelle Sorixelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, got the docker changes out of here. Looks good now, thanks for the contribution! Just fix up the commit lints in this run and we should be good to merge.

@saltedlolly
Copy link
Author

Would you mind if I DM you on Discord? I spent hours trying to figure out how to split the commits into differnent PRs, and I would really like to understand how to do it. My knowledge of basic Github stuff has been okay for years, but I am not a professional developer, only a hobbyist, and struggle to understand the more advanced stuff. I spent ages on over
the weekend trying to figure out and kept making it worse!

@saltedlolly
Copy link
Author

Ok well this has been a learning experience. Finally unscrambled.

@saltedlolly
Copy link
Author

saltedlolly commented Aug 12, 2025

No worries, got the docker changes out of here. Looks good now, thanks for the contribution! Just fix up the commit lints in this run and we should be good to merge.

Ther lint error appears to be about the comment above being too long? I have no idea what that is about. Does that make sense to you?

Commit bdcd15d:
1: CC1 Body does not contain a 'Signed-off-by' line
3: B1 Line exceeds max length (305>80): "Some of the information is incomplete at this stage, since it is still not confirmed. I could not find any information as to what CPU the Pebble 2 Duo is. I suspect it is the same as the Pebble 2, but am not certain. If I get more information in future I will make another PR to fill out the missing data."
Error: Process completed with exit code 13.

Update: I edited the comment to make it shorter. Let's see if it accepts it now.

@saltedlolly
Copy link
Author

Screenshot 2025-08-14 at 1 36 58 am

@Sorixelle
Copy link
Member

Commit length is good, but still need the Signed-off-by lines - see the contribution guides

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: content Changes to files that include developer documentation content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants