Gmiguel.2 #21
Open
Gmiguel.2 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ming1in
reviewed
Oct 5, 2020
Collaborator
ming1in
left a comment
ming1in
left a comment
There was a problem hiding this comment.
should move files over to match the current file structure. also perhaps not necessary to push output .txt files to the repo, since its something utilized for individual local dev?
Comment on lines
+3
to
+6
| sys.path.append("C:\\Users\\Stevens User\\Documents\\GitHub\\Team-4-Code\\seeds") | ||
| sys.path.append("C:\\Users\\Stevens User\\Documents\\GitHub\\Team-4-Code\\GMiguel") | ||
| sys.path.append("c:\\Users\\Stevens User\\Documents\\GitHub\\Team-4-Code\\src") | ||
| import user02 |
Collaborator
There was a problem hiding this comment.
should not use absolute file names rather use relative imports. this will not work on other peoples computers as the paths are not the same. Let me know if you need help with relative imports
Comment on lines
6
to
+7
| sys.path.append("c:\\Users\\Stevens User\\Documents\\GitHub\\Team-4-Code\\src") | ||
| sys.path.append("C:\\Users\\Stevens User\\Documents\\GitHub\\Team-4-Code\\testFiles") | ||
| sys.path.append("C:\\Users\\Stevens User\\Documents\\GitHub\\Team-4-Code\\seeds") |
Collaborator
There was a problem hiding this comment.
same here should be using relative imports
ming1in
reviewed
Oct 5, 2020
Collaborator
ming1in
left a comment
ming1in
left a comment
There was a problem hiding this comment.
make sure to pull down master before doing any development to avoid these merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.