BUG: only add delay tag if there is a non-0 delay specified

[tangkong]

As the title says, we should only include the <delay> xml tag if there is a delay to report. It defaults to 0 on the phoebus side.

Rabbit hole:
The way we're generating xml files here is a little circuitous. We create an ElementTree and produce its string representation, only to re-parse it into a minidom and pretty-print it again. The only difference this produces is in the <?xml version="1.0" ?> at the beginning of the file, where the encoding may show up.

I've not changed this here, but it's not so hard to just omit minidom and use xml.etree.ElementTree the whole way.

[KaushikMalapati]

This looks good to me, but should we do the same thing for Description? There are some entries in KFE/SXR-EBD that have no description and generate in the xml.

https://github.com/ControlSystemStudio/phoebus/blob/c443eb093ce17bcb2c12517fc21040cec7ff2a36/app/alarm/examples/alarm_configuration.xsd#L52

[tangkong]

You're right, the description and delay fields look similar in configuration according to that .xsd you shared. I'll confirm with Thorsten just to make sure.

[KaushikMalapati]

Can you ask thorsten if having component tags like
<component name="CRIX"/>
is ok?

They generate for all our empty configurations

(pcds-5.9.1) [kaushikm@tmo-daq tk-nalsm]$ grep -r "/>"
Binary file .git/objects/pack/pack-74aa568e69cc4ccb100102b9a9dd8166a3b915f2.pack matches
XML/KFE/CRIX-alarms.xml:   <component name="CRIX"/>
XML/KFE/QRIX-alarms.xml:   <component name="QRIX"/>
XML/LFE/CXI-alarms.xml:   <component name="CXI"/>
XML/LFE/XCS-alarms.xml:   <component name="XCS"/>
XML/LFE/MEC-alarms.xml:   <component name="MEC"/>
XML/LFE/MFX-alarms.xml:   <component name="MFX"/>
XML/LFE/XPP-alarms.xml:   <component name="XPP"/>

Everything else looks good