set latching to True if unspecified #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to close #39
I thought the change I previously made to phoebus would have done this, but I did not try it on the self-closing tags that our xmls use if the csv value is not provided, I think because of the short_empty_elements in https://github.com/KaushikMalapati/pcds-nalms/blob/3dc96c817de3ab283c8b33ba0319681919317574/Scripts/alarm_csv2xml.py#L45-L47
I think latching by default is the expected behavior. Non-latching alarms seem not very useful to me at least, but alarms can still be set not to latch explicitly.