Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: some nonsense changes to configs #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tangkong
Copy link
Contributor

I imagine we can just open and close this as needed to try to trigger comment diffs

@tangkong
Copy link
Contributor Author

--- a/Spreadsheet/KFE/CRIX-alarms.csv
+++ b/Spreadsheet/KFE/CRIX-alarms.csv

@@#IndentBranchPVDescriptionLatchDelayFilterGuidance
0CRIXNULL→
+++1GMD high voltage
+++EM2K0:XGMD:SHV:01:Crate:PowerOnHigh voltage crate powered onFALSE0
+++EM2K0:XGMD:SHV:01:M0:isSafetyLoopGoodSafety loop okFALSE0

1 similar comment
@tangkong
Copy link
Contributor Author

--- a/Spreadsheet/KFE/CRIX-alarms.csv
+++ b/Spreadsheet/KFE/CRIX-alarms.csv

@@#IndentBranchPVDescriptionLatchDelayFilterGuidance
0CRIXNULL→
+++1GMD high voltage
+++EM2K0:XGMD:SHV:01:Crate:PowerOnHigh voltage crate powered onFALSE0
+++EM2K0:XGMD:SHV:01:M0:isSafetyLoopGoodSafety loop okFALSE0

@tangkong
Copy link
Contributor Author

It's working! 🎉

But i think it comments once per commit. Probably need to check if the most recent commit introduces changes? Or live with spam?

@tangkong tangkong closed this Dec 20, 2024
@tangkong tangkong reopened this Dec 20, 2024
@pcds-bot
Copy link

--- a/Spreadsheet/KFE/CRIX-alarms.csv
+++ b/Spreadsheet/KFE/CRIX-alarms.csv

@@#IndentBranchPVDescriptionLatchDelayFilterGuidance
0CRIXNULL→
+++1GMD high voltage
+++EM2K0:XGMD:SHV:01:Crate:PowerOnHigh voltage crate powered onFALSE0
+++EM2K0:XGMD:SHV:01:M0:isSafetyLoopGoodSafety loop okFALSE0

@KaushikMalapati
Copy link
Contributor

I forgot about that. In thollander/actions-comment-pull-request you can use a comment-tag to make it update the same comment. Let me see if I can find something similar in the rest api. Might also want to restrict the pull_reqest trigger to only synchronize so we don't get double runs when opening?

@KaushikMalapati
Copy link
Contributor

I looked into what the thollander action did - it just added an html style comment to the comment it posted like
<!-- thollander/actions-comment-pull-request "name_of_tag" -->
I can make a pr that will use the same rest api we used to create a comment to look for comments with an html comment, editing it if present and creating a new comment if not to sotp the spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants