moving sp1k4 and im5k4 camera sync into daq #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Apr 5, 2024
Spreadsheet/KFE/TMO-alarms.csv
Outdated
Comment on lines
89
to
93
| ,,SP1K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,, | ||
| ,,SP1K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,, | ||
| 1,IM5K4 | ||
| ,,IM5K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,, | ||
| ,,IM5K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,, |
There was a problem hiding this comment.
Each line should have exactly 7 commas or the parser breaks
Suggested change
| ,,SP1K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,, | |
| ,,SP1K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,, | |
| 1,IM5K4 | |
| ,,IM5K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,, | |
| ,,IM5K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,, | |
| ,,SP1K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,,, | |
| ,,SP1K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,,, | |
| 1,IM5K4,,,,,, | |
| ,,IM5K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,,, | |
| ,,IM5K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,,, |
There was a problem hiding this comment.
Thanks Zach. I fix it. It is strange that all previous PV has less comma. But I fixed those according to your suggestion.
ZLLentz
reviewed
Apr 8, 2024
Spreadsheet/KFE/TMO-alarms.csv
Outdated
Comment on lines
89
to
93
| ,,SP1K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,,, | ||
| ,,SP1K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,,, | ||
| 1,IM5K4,,,,,, | ||
| ,,IM5K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,,, | ||
| ,,IM5K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,,, |
There was a problem hiding this comment.
I miscounted, only the IM5K4 line needed an adjustment previously
Suggested change
| ,,SP1K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,,, | |
| ,,SP1K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,,, | |
| 1,IM5K4,,,,,, | |
| ,,IM5K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,,, | |
| ,,IM5K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,,, | |
| ,,SP1K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,, | |
| ,,SP1K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,, | |
| 1,IM5K4,,,,,, | |
| ,,IM5K4:PPM:CAM:TSS:SyncStatus,Camera Sync Status,,,, | |
| ,,IM5K4:PPM:CAM:TSS:DiffVsIntAvg,Sync Diff,,,, |
There was a problem hiding this comment.
I updated again, Zach.
|
All checks passed, marking as ready and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
James wants to move IM5K4 and SP1K4 camera sync PV into daq in alarm system