adding tmo daq damage pv #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Mar 25, 2024
ZLLentz
reviewed
Mar 26, 2024
|
It looks good to me now but the csv converter is unhappy, so there must be something slightly wrong. We'll have to look really closely at what is here and what the checker is doing. |
ZLLentz
reviewed
Mar 26, 2024
Spreadsheet/KFE/TMO-alarms.csv
Outdated
Comment on lines
88
to
92
| ,,pva://DAQ:NEH:tmo:0:DeadFrac,,,, | ||
| ,,pva://DAQ:NEH:tmo:0:Damage_hsd,,,, | ||
| ,,pva://DAQ:NEH:tmo:0:Damage_bld,,,, | ||
| ,,pva://DAQ:NEH:tmo:0:Damage_epics,,,, | ||
| ,,pva://DAQ:NEH:tmo:0:Damage_atm,,,, |
There was a problem hiding this comment.
I figured out that these are all missing a comma, and this ends up breaking the build
Suggested change
| ,,pva://DAQ:NEH:tmo:0:DeadFrac,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_hsd,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_bld,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_epics,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_atm,,,, | |
| ,,pva://DAQ:NEH:tmo:0:DeadFrac,,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_hsd,,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_bld,,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_epics,,,,, | |
| ,,pva://DAQ:NEH:tmo:0:Damage_atm,,,,, |
There was a problem hiding this comment.
Thank you so much Zach! I changed it
|
OK all the checks pass now, I will merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TMo wants to add daq damge PV to track daq during beam time. Daq team and James already test those PVs.