Merge pull request #55 from tangkong/bld_daff_perms

WIP/BLD: daff perms

.github/workflows/daff.yml

@@ -1,7 +1,7 @@
 name: Comment Diff
 
 on:
-  pull_request_target:
+  pull_request:
     paths:
       - 'Spreadsheet/**'
 
@@ -37,10 +37,11 @@ jobs:
         git config set --global diff.daff-csv.command "daff diff --git --output-format html --fragment --context 0"
         git remote add target https://github.com/pcdshub/pcds-nalms.git
         git fetch target
-        git diff target/${{ github.event.pull_request.base.ref }}...HEAD Spreadsheet/ > ${{ runner.temp }}/diff.txt
+        mkdir -p ./pr
+        git diff target/${{ github.event.pull_request.base.ref }}...HEAD Spreadsheet/ > pr/diff.txt
+        echo ${{ github.event.number }} > ./pr/NR
 
-    - name: make comment
-      uses: thollander/actions-comment-pull-request@v3
+    - uses: actions/upload-artifact@v4
       with:
-        file-path: ${{ runner.temp }}/diff.txt
-        comment-tag: csvdiff
+        name: diff
+        path: pr/ 

.github/workflows/makecomment.yml

@@ -0,0 +1,51 @@
+name: Comment on the pull request
+on:
+  workflow_run:
+    workflows: ["Comment Diff"]
+    types:
+      - completed
+
+jobs:
+  upload:
+    runs-on: ubuntu-latest
+    if: >
+      github.event.workflow_run.event == 'pull_request' &&
+      github.event.workflow_run.conclusion == 'success'
+    steps:
+      - name: 'Download artifact'
+        uses: actions/github-script@v7
+        with:
+          script: |
+            var artifacts = await github.actions.listWorkflowRunArtifacts({
+               owner: context.repo.owner,
+               repo: context.repo.repo,
+               run_id: ${{ github.event.workflow_run.id }},
+            });
+            var matchArtifact = artifacts.data.artifacts.filter((artifact) => {
+              return artifact.name == "diff"
+            })[0];
+            var download = await github.actions.downloadArtifact({
+               owner: context.repo.owner,
+               repo: context.repo.repo,
+               artifact_id: matchArtifact.id,
+               archive_format: 'zip',
+            });
+            var fs = require('fs');
+            fs.writeFileSync('${{ github.workspace }}/pr.zip', Buffer.from(download.data));
+      - run: unzip pr.zip
+
+      - name: 'Comment on PR'
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.COMMENT_TOKEN }}
+          script: |
+            var fs = require('fs');
+            var issue_number = Number(fs.readFileSync('./NR'));
+            var diff_text = String(fs.readFileSync('./diff.txt'));
+
+            await github.issues.createComment({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: issue_number,
+              body: diff_text 
+            });

Spreadsheet/KFE/QRIX-alarms.csv

@@ -1,3 +1,2 @@
 #Indent,Branch,PV,Description,Latch,Delay,Filter,Guidance
 0,QRIX,,,,,,
-,,MR1K1:BEND:RTD:US:1_RBV,TEMPERATURE,,,,