DOD code merge to run 21. #46
Conversation
There was a problem hiding this comment.
Looks fine to me - @lg345 can you decide on the naming for the lxe object? Otherwise a couple quick changes and it can be merged.
mfx/beamline.py
Outdated
| f"/reg/neh/operator/mfxopr/experiments/{get_current_experiment('mfx')}/wpcalib" | ||
| ) | ||
| try: | ||
| lxe_pw = LXE("MFX:LAS:MMN:08", calibration_file=lxe_calib_file, name="lxe_pw") |
There was a problem hiding this comment.
Are people happy with this nomenclature? When I added it in I didn't want to conflict with any objects others may have been trying to create at the time. If you'd prefer lxe to lxe_pw we should probably make that change before merging. It's probably useful to keep things consistent with muscle memory people have from moving between hutches?
There was a problem hiding this comment.
lxe will be the final name for the object.
mfx/beamline.py~
Outdated
There was a problem hiding this comment.
This file should be untracked and removed. It's a backup emacs file which is not needed in the repo.
mfx/focus_scan.py
Outdated
There was a problem hiding this comment.
Looks fine to me. This was tested and found to still work during mfxx1006522 right?
No description provided.