MDL-54589 behat: Fixed failures for phantomjs standalone

pbhwheeler · Jun 20, 2016 · f55d87c · f55d87c
1 parent 6a51c58
commit f55d87c
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 2 deletions.
diff --git a/blocks/private_files/tests/behat/block_private_files_dashboard.feature b/blocks/private_files/tests/behat/block_private_files_dashboard.feature
@@ -1,4 +1,4 @@
-@block @block_private_files @file_upload @javascript
+@block @block_private_files @_file_upload @javascript
 Feature: The private files block allows users to store files privately in moodle
   In order to store a private file in moodle
   As a user

diff --git a/blocks/private_files/tests/behat/block_private_files_frontpage.feature b/blocks/private_files/tests/behat/block_private_files_frontpage.feature
@@ -1,4 +1,4 @@
-@block @block_private_files @file_upload
+@block @block_private_files @_file_upload
 Feature: The private files block allows users to store files privately in moodle
   In order to store a private file in moodle
   As a teacher

diff --git a/enrol/tests/behat/behat_enrol.php b/enrol/tests/behat/behat_enrol.php
@@ -58,6 +58,9 @@ public function i_add_enrolment_method_with($enrolmethod, TableNode $table) {
             array($this->escape($enrolmethod), get_string('addinstance', 'enrol'))
         );
 
+        // Wait again, for page to reloaded.
+        $this->execute('behat_general::i_wait_to_be_redirected');
+
         // Set form fields.
         $this->execute("behat_forms::i_set_the_following_fields_to_these_values", $table);
 

diff --git a/mod/feedback/tests/behat/behat_mod_feedback.php b/mod/feedback/tests/behat/behat_mod_feedback.php
@@ -54,6 +54,9 @@ public function i_add_question_to_the_feedback_with($questiontype, TableNode $qu
 
         $this->execute('behat_forms::i_select_from_the_singleselect', array($questiontype, $additem));
 
+        // Wait again, for page to reloaded.
+        $this->execute('behat_general::i_wait_to_be_redirected');
+
         $rows = $questiondata->getRows();
         $modifiedrows = array();
         foreach ($rows as $row) {

diff --git a/mod/forum/tests/behat/discussion_navigation.feature b/mod/forum/tests/behat/discussion_navigation.feature
@@ -39,9 +39,11 @@ Feature: A user can navigate to previous and next discussions
     And I add a new discussion to "Test forum name" forum with:
       | Subject | Discussion 1 |
       | Message | Test post message |
+    And I wait "1" seconds
     And I add a new discussion to "Test forum name" forum with:
       | Subject | Discussion 2 |
       | Message | Test post message |
+    And I wait "1" seconds
     And I add a new discussion to "Test forum name" forum with:
       | Subject | Discussion 3 |
       | Message | Test post message |

diff --git a/mod/quiz/tests/behat/editing_add.feature b/mod/quiz/tests/behat/editing_add.feature
@@ -153,6 +153,7 @@ Feature: Edit quiz page - adding things
 
     # Create the Essay 03 question.
     And I set the field "Select a category" to "Default for C1"
+    And I wait until the page is ready
     When I press "Create a new question ..."
     And I set the field "qtype_qtype_essay" to "1"
     And I press "Add"

diff --git a/report/eventlist/tests/behat/mainsection.feature b/report/eventlist/tests/behat/mainsection.feature
@@ -10,6 +10,7 @@ Feature: Page contains a list of events
     And I navigate to "Events list" node in "Site administration > Reports"
     And I should see "Event name"
     And I set the field "eventname" to "phase"
+    And I press "filterbutton"
     And I should see "Phase switched"
     And I should not see "Comment created"
     And I press "clearbutton"