MDL-54977 blocks_navigation: Use html_writer::random_id for id

uniqid() may returns the same id for faster machines (seen on iis) so use html_writer::random_id(), to ensure id is different and navigation don't break
pbhwheeler · Jul 13, 2016 · 560cea8 · 560cea8
1 parent 5a1728d
commit 560cea8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/blocks/navigation/renderer.php b/blocks/navigation/renderer.php
@@ -86,7 +86,7 @@ protected function navigation_node($items, $attrs=array(), $expansionlimit=null,
                 continue;
             }
 
-            $id = $item->id ? $item->id : uniqid();
+            $id = $item->id ? $item->id : html_writer::random_id();
             $content = $item->get_content();
             $title = $item->get_title();
             $ulattr = ['id' => $id . '_group', 'role' => 'group'];

diff --git a/blocks/settings/renderer.php b/blocks/settings/renderer.php
@@ -75,7 +75,7 @@ protected function navigation_node(navigation_node $node, $attrs=array(), $depth
             }
 
             $content = $this->output->render($item);
-            $id = $item->id ? $item->id : uniqid();
+            $id = $item->id ? $item->id : html_writer::random_id();
             $ulattr = ['id' => $id . '_group', 'role' => 'group'];
             $liattr = ['class' => [$item->get_css_type(), 'depth_'.$depth], 'tabindex' => '-1'];
             $pattr = ['class' => ['tree_item'], 'role' => 'treeitem'];