feat: clarify that promises are being passed to start #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanReinstein
approved these changes
Nov 7, 2025
Contributor
EvanReinstein
left a comment
EvanReinstein
left a comment
There was a problem hiding this comment.
Looks great! Good thinking @nbierdeman !
nbierdeman
force-pushed
the
DTPPCPSDK-3989-clarify-start
branch
2 times, most recently
from
4fa6d0c to
25dce62
Compare
nbierdeman
requested review from
bdellis,
gregjopa and
wsbrunson
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds or renames
consts to clarify that Promises are being passed tostart().