fix(ui): clear miliseconds in date fields unless theyre explicitly provided in the display format #12650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpopus
changed the title
paulpopus
deleted the
fix/ui-clear-miliseconds-unless-theyre-explicitly-provided-in-the-display-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12532
Normally we clear any values when picking a date such that your hour, minutes and seconds are normalised to 0 unless specified. Equally when you specify a time we will normalise seconds so that only minutes are relevant as configured.
Miliseconds were never removed from the actual date value and whatever milisecond the editor was in was that value that was being added. There's this abandoned issue from the UI library
react-datepickeras it's not something configurable.This fixes that problem by making sure that miliseconds are always 0 unless the
displayFormatincludesSSSas an intention to show and customise them.This also caused issues with scheduled jobs if things were slightly out of order or not being scheduled in the expected time interval.