Skip to content

WIP - sender fallback method#1543

Draft
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
arminsabouri:fallback-method
Draft

WIP - sender fallback method#1543
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
arminsabouri:fallback-method

Conversation

@arminsabouri
Copy link
Copy Markdown
Collaborator

POC an alternative to manually pushing fallback related events to the persistence layer. spawned from a dicsussion on #1542 (comment).

I hate the giant match statement. For the recv it will be even more boilerplate. And if we go this route we will probably need an async version fallback()

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25558215424

Coverage decreased (-0.07%) to 85.097%

Details

  • Coverage decreased (-0.07%) from the base build.
  • Patch coverage: 14 uncovered changes across 3 files (15 of 29 lines covered, 51.72%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
payjoin/src/core/receive/v2/mod.rs 9 0 0.0%
payjoin-cli/src/app/v2/mod.rs 9 5 55.56%
payjoin/src/core/send/v2/session.rs 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13548
Covered Lines: 11529
Line Coverage: 85.1%
Coverage Strength: 399.16 hits per line

💛 - Coveralls

@arminsabouri arminsabouri marked this pull request as draft May 8, 2026 19:40
@arminsabouri arminsabouri marked this pull request as draft May 8, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants