Cleanup python devshell CI testing environment#1539
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom May 7, 2026
Merged
Cleanup python devshell CI testing environment#1539spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
There were some regressions following 4285965 that broke the python tests. We need to do a few things to fix it. - Ensure that the runner has access to bzip2 at runtime - Ensure that the bitcoind download is skipped and the nix version is used instead - use the rustup target available in the nix flake at the job level and to skip rustup target add when inside of the dev shell
spacebear21
approved these changes
May 7, 2026
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
utACK - have you validated this with a python CI job run?
Collaborator
Coverage Report for CI Build 25523658132Coverage remained the same at 85.169%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
Author
|
It passed in the run from the other PR https://github.com/payjoin/rust-payjoin/actions/runs/25518130576/job/74894717151?pr=1536 but also looks promising here at the moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1538
There were some regressions following
4285965 that broke the python tests. We need to do a few things to fix it.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.