Expose InMemoryPersister in FFI#1533
Open
spacebear21 wants to merge 4 commits intopayjoin:masterfrom
Open
Conversation
Collaborator
Coverage Report for CI Build 25525571946Coverage remained the same at 85.169%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
5 tasks
spacebear21
force-pushed
the
ffi-in-memory-persister
branch
2 times, most recently
from
007c61e to
b5385f0
Compare
9df60104aca83375f084f517de5a77c7d257afc6 introduced a fix for callback traits necessary for using InMemoryPersister in dart bindings.
This exposes in-memory implementations of the JSON session persister traits, as a counterpart to the InMemoryPersister trait which is now exposed in the Rust library
Instead of re-implementing the same persister in each language, we can now use the InMemoryPersister wrappers exposed in the FFI bindings.
Move the preexisting JSON persister traits and callback adapters to persist.rs for clearer organization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1529
One deviation from that spec is that I chose not to feature gate them behind
_test-utils. That seems like unnecessary complexity which also deviates from the core rust library. Since we expose InMemoryPersister there for "production" I think it makes sense to expose that utility in the FFI surface too.Implementation by Claude Opus 4.7
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.