Skip to content

Move Hashable, Comparable conformance to DeclarationType. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: typed-declarations
Choose a base branch
from

Conversation

paulyoung
Copy link
Owner

@paulyoung
Copy link
Owner Author

cc @jpsim

@jpsim
Copy link

jpsim commented Dec 4, 2015

I'm wondering what's preferable: having dedicated SwiftDeclaration and ObjCDeclaration structs, or a single Declaration that exposes the joined set of members from both languages, asserting at runtime if trying to get say the ACL of an Objective-C declaration. Sorry for the back and forth on this, it just seems like having that represented in the type system might be adding more complexity when it's not necessary. Thoughts?

@paulyoung
Copy link
Owner Author

No worries. Sometimes you've got to see the complexity of something before you can simplify it.

I'm not doing much with Objective-C these days and try to leverage Swift's type system as much as possible, but I don't have a real preference here provided that the original issue I raised is addressed: jpsim#87 (comment)

@jpsim
Copy link

jpsim commented Dec 4, 2015

Yeah, I hear you, and totally appreciate your work on this. I just want to make sure we're on the right track!

@yoiang
Copy link

yoiang commented Mar 16, 2016

Hey y'all, any progress regarding this, #2 and related? Any way I can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants