-
Notifications
You must be signed in to change notification settings - Fork 376
chore(actions): fix failing workflow using outputs #12179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request modifies the GitHub Actions workflow configuration to enhance the team membership check logic. The team membership checker step now includes an explicit step ID, changes its exit behavior, and gates the subsequent label-application step with a conditional that only runs upon successful team membership validation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Comment |
|
Preview: https://pf-react-pr-12179.surge.sh A11y report: https://pf-react-pr-12179-a11y.surge.sh |
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Currently, the workflow at
https://github.com/patternfly/patternfly-react/blob/main/.github/workflows/add-new-issues-to-project.yml
fails whenever an issue is opened by a contributor who is not a member of the configured team. This results in unnecessary workflow failures and a poor developer experience for external contributors.
Example: https://github.com/patternfly/patternfly-react/actions/runs/20227457367/job/58062113822
They might even get failure emails from GitHub.
This change updates the workflow to gracefully handle non-team contributors by skipping the team-specific labeling step instead of failing the job. As a result, issues opened by external contributors are still added to the project without causing workflow errors, while team members continue to be labeled correctly.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.