Skip to content

Conversation

@gautamkrishnar
Copy link
Contributor

@gautamkrishnar gautamkrishnar commented Dec 15, 2025

Currently, the workflow at
https://github.com/patternfly/patternfly-react/blob/main/.github/workflows/add-new-issues-to-project.yml
fails whenever an issue is opened by a contributor who is not a member of the configured team. This results in unnecessary workflow failures and a poor developer experience for external contributors.

Example: https://github.com/patternfly/patternfly-react/actions/runs/20227457367/job/58062113822

They might even get failure emails from GitHub.

This change updates the workflow to gracefully handle non-team contributors by skipping the team-specific labeling step instead of failing the job. As a result, issues opened by external contributors are still added to the project without causing workflow errors, while team members continue to be labeled correctly.

Summary by CodeRabbit

  • Chores
    • Updated internal automation workflow configuration to improve issue processing reliability and handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Walkthrough

This pull request modifies the GitHub Actions workflow configuration to enhance the team membership check logic. The team membership checker step now includes an explicit step ID, changes its exit behavior, and gates the subsequent label-application step with a conditional that only runs upon successful team membership validation.

Changes

Cohort / File(s) Summary
Workflow Configuration
​.github/workflows/add-new-issues-to-project.yml
Added step ID "teamcheck" to Team Membership Checker; changed exit behavior from exit: true to exit: false; added conditional to "Add label if user is a team member" step so it only executes when team membership check passes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the conditional syntax (permitted == 'true') correctly references the step output
  • Confirm the exit behavior change (exit: false) aligns with the workflow's error-handling expectations
  • Ensure the gated step doesn't inadvertently skip legitimate labeling scenarios

Poem

🐰 A check now stands at workflow's gate,
With "teamcheck" to validate the state,
No exit crash, but gentle flow,
Conditions guard what we bestow—
Membership rules now gently guiding bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing a failing workflow by using GitHub Actions outputs to handle team membership checks conditionally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5053dd and aad593b.

📒 Files selected for processing (1)
  • .github/workflows/add-new-issues-to-project.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build
  • GitHub Check: Build, test & deploy
🔇 Additional comments (2)
.github/workflows/add-new-issues-to-project.yml (2)

33-40: Conditional syntax is correct for the workflow.

The conditional if: steps.teamcheck.outputs.permitted == 'true' uses the proper GitHub Actions syntax for step output references and string comparison. Once you confirm the output name from the action, this will correctly gate the label-application step.


18-31: Graceful error handling approach is correctly implemented.

The changes properly implement the fix: adding step ID teamcheck, setting exit: false to allow the workflow to continue on non-membership, and gating the labeling step with the conditional if: steps.teamcheck.outputs.permitted == 'true'. The output name permitted is correctly referenced—it's confirmed as a standard boolean output from the TheModdingInquisition/[email protected] action. The implementation aligns well with the PR objective to handle non-team contributors without job failure.


Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Dec 15, 2025

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wise-king-sullyman wise-king-sullyman merged commit a9b02b1 into patternfly:main Dec 17, 2025
14 checks passed
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

Thanks for your contribution! 🎉

@gautamkrishnar gautamkrishnar deleted the patch-1 branch December 17, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants