fix(Wizard): Fix crash in nav when first sub-step is hidden #12166
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://pf-react-pr-12166.surge.sh A11y report: https://pf-react-pr-12166-a11y.surge.sh |
nicolethoen
approved these changes
Dec 11, 2025
Contributor
|
@ochosi it looks like there is a linting error that needs to be resolved: |
Update logic to focus on the first visible sub-step when navigating from a parent step.
ochosi
force-pushed
the
fix-wizard-hidden-active-step
branch
from
df9d575 to
02ef4b0
Compare
Contributor
Author
|
@nicolethoen Thanks for the swift review, and apologies for not noticing the linting error. I guess it'd be convenient if the linter would run on all PRs (for everyone not reading the project's README and using The linting error is now resolved. |
nicolethoen
approved these changes
Dec 15, 2025
wise-king-sullyman
approved these changes
Dec 15, 2025
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Fix looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update logic to focus on the first visible sub-step when navigating from a parent step.
What: Fixes #12165
Additional issues: