Skip to content

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Nov 25, 2025

fixes #12153

A couple of thoughts

  • This adds 2800 icons to the static dir and that dir is 11mb. Want to make sure that's OK.
  • Longer term, if we end up using static SVGs in core and move away from the icon fonts, react icons would be the single source of truth for our icons, and should maintain the current definitions for pficons, and new icons would be added through react-icons instead of core.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Nov 25, 2025

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! I don't think the added dir to the icons build should make too much of a difference because it should tree shake out unused icons if I understand that process correctly (or users would import directly from the dist).

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the size is okay since it's 11mb and people can always just import what they need.

@dlabaj dlabaj merged commit 3d2fd6f into patternfly:main Dec 3, 2025
13 checks passed
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-icons - generate static SVGs

4 participants