feat(Compass): updated mainheader structure to be composable #12135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://pf-react-pr-12135.surge.sh A11y report: https://pf-react-pr-12135-a11y.surge.sh |
kmcfaul
reviewed
Nov 11, 2025
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
Overall looking good to me, just had one comment about reusing the new components internally and it'll need a rebase once the Hero PR goes in!
| import { css } from '@patternfly/react-styles'; | ||
|
|
||
| interface CompassPanelProps extends React.HTMLProps<HTMLDivElement> { | ||
| export interface CompassPanelProps extends React.HTMLProps<HTMLDivElement> { |
Contributor
There was a problem hiding this comment.
Doh! That may be why some the props tables were broken
| <div className={css(`${styles.compass}__main-header-content`)}> | ||
| {title && <div className={css(`${styles.compass}__main-header-title`)}>{title}</div>} | ||
| {toolbar && <div className={css(`${styles.compass}__main-header-toolbar`)}>{toolbar}</div>} | ||
| </div> |
Contributor
There was a problem hiding this comment.
I think we should use the new CompassMainHeaderContent/CompassMainHeaderTitle/CompasMainHeaderToolbar here instead of creating the divs again. But not a blocker
kmcfaul
approved these changes
Nov 12, 2025
thatblindgeye
force-pushed
the
iss12108
branch
from
13acd8d to
aad0234
Compare
wise-king-sullyman
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #12108
Will need to wait on #12131 going in first; made updates to CompassHero just to appease the precommit checks.
Additional issues: