fix(examples): make sure examples with SearchInput have onClear #12044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitdallas <[email protected]>
|
Preview: https://pf-react-pr-12044.surge.sh A11y report: https://pf-react-pr-12044-a11y.surge.sh |
gitdallas
requested review from
kmcfaul,
thatblindgeye,
tlabaj and
wise-king-sullyman
wise-king-sullyman
approved these changes
Oct 9, 2025
nicolethoen
requested changes
Oct 9, 2025
packages/react-core/src/demos/CustomMenus/examples/InlineSearchFilterMenuDemo.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: gitdallas <[email protected]>
dlabaj
approved these changes
Oct 10, 2025
kmcfaul
approved these changes
Oct 10, 2025
nicolethoen
approved these changes
Oct 13, 2025
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8318
dual list selector was already fixed.
this fixes examples/demos:
MenuFilterDrilldown
MenuFilteringWithSearchInput
ToolbarContentWrap
ToolbarItems
ToolbarSticky
CustomMenus InlineSearchFilterMenuDemo
DataListExpandableControlInToolbar
MastheadWithUtilitiesAndUserDropdownMenu
MenuDemo in react-integration (not sure if necessary 😆 )