feat(CC-expandable-section): added expandable section #11930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11930.surge.sh A11y report: https://patternfly-react-pr-11930-a11y.surge.sh Preview: https://pf-react-pr-11930.surge.sh A11y report: https://pf-react-pr-11930-a11y.surge.sh |
mattnolting
commented
Jul 22, 2025
| <ExpandableSection | ||
| onToggle={() => {}} | ||
| toggleText={isExpanded ? 'Show less basic example content' : `${props.toggleText}`} | ||
| > |
There was a problem hiding this comment.
stub out isExpanded={false/true} doesn't need to be connected to figma, true/false are acceptable values.
mattnolting
commented
Jul 22, 2025
| <ExpandableSection | ||
| isExpanded | ||
| onToggle={() => {}} | ||
| toggleText={isExpanded ? `${props.toggleText}` : 'Show less basic example content'} |
There was a problem hiding this comment.
'Show more basic example content'
mattnolting
commented
Jul 22, 2025
| example: (props) => ( | ||
| <Stack hasGutter> | ||
| <StackItem> | ||
| <ExpandableSection isExpanded={false} isDetached toggleId={props.toggleId} contentId={props.contentId}> |
There was a problem hiding this comment.
isExpanded={true}
mattnolting
commented
Jul 22, 2025
| toggleId={props.toggleId} | ||
| contentId={props.contentId} | ||
| direction="up" | ||
| > |
There was a problem hiding this comment.
isExpanded={true}
mattnolting
commented
Jul 22, 2025
| example: (props) => ( | ||
| <ExpandableSection | ||
| toggleText={isExpanded ? `${props.toggleText}` : 'Show less indented example content'} | ||
| isExpanded={isExpanded} |
There was a problem hiding this comment.
Suggested change
| isExpanded={isExpanded} | |
| isExpanded={true} |
mattnolting
commented
Jul 22, 2025
| 'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2404-21', | ||
| { | ||
| variant: { State: 'Default Custom Content' }, | ||
| example: () => ( |
There was a problem hiding this comment.
Pass shared const into examples so user can see them, contextually.
mattnolting
commented
Jul 22, 2025
| <ExpandableSection | ||
| isExpanded={isExpanded} | ||
| onToggle={() => {}} | ||
| toggleText={isExpanded ? `${props.toggleText}` : 'Show less basic example content'} |
There was a problem hiding this comment.
Suggested change
| toggleText={isExpanded ? `${props.toggleText}` : 'Show less basic example content'} | |
| toggleText={isExpanded ? `${props.toggleText}` : 'Show more basic example content'} |
mattnolting
force-pushed
the
feat-CC-expandable-section
branch
from
ae0a1a6 to
d51c5aa
Compare
mattnolting
force-pushed
the
feat-CC-expandable-section
branch
from
d51c5aa to
5fa8d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #11624
Included components:
ExpandableSection
Component tracker
Figma preview
Resources: