Skip to content

chore(chart bullet): convert to typescript part two #11758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Apr 12, 2025

Towards #11719
Related to #11756
Since there are in total 17 examples I have the divided work it into two PRs.

The following examples of ChartArea will be converted to TypeScript:

  • Vertical with segmented primary measure
  • Vertical primary measure outside max range
  • Custom labels
  • Custom size
  • Horizontal group
  • Vertical group
  • Horizontal group with title
  • Vertical group with title

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 12, 2025

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 12, 2025

@thatblindgeye both the PRs are ready for review.
I have not created interfaces and variables for Horizontal group, Vertical group, Horizontal group with title, Vertical group with title since they have many variables to deal with (could make the code look messy). Let me know what you think.

@Mash707 Mash707 mentioned this pull request Apr 12, 2025
17 tasks
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine, but it would be nice to reduce the repetitive lines of code with some variables (e.g. the primarySegmentedMeasureData prop if it's being repeated with the same values in a single example).

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 14, 2025

Nice catch, I didn't check if variables are repeating, will make the necessary changes.

@Mash707 Mash707 requested a review from thatblindgeye April 14, 2025 17:55
@nicolethoen nicolethoen merged commit 3ff2e05 into patternfly:main Apr 21, 2025
13 checks passed
@Mash707 Mash707 deleted the convert-chart-bullet-to-typescript-part-two branch April 21, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants