Add the React Compiler linter #11139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-11139.surge.sh A11y report: https://patternfly-react-pr-11139-a11y.surge.sh |
kmcfaul
approved these changes
Nov 8, 2024
Closes patternfly#11137 Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
react-compiler-linter
branch
from
4bcc4f9 to
22d4376
Compare
dlabaj
reviewed
Nov 8, 2024
| radix: ['error', 'as-needed'], | ||
| 'react/prop-types': 0, | ||
| 'react/display-name': 0, | ||
| 'react-compiler/react-compiler': 'warn', |
Contributor
There was a problem hiding this comment.
I assume at some point we want to change this to error out when we move to react 19? @tlabaj Do we need a story to revisit this in the future.
Contributor
Author
There was a problem hiding this comment.
The error value can be set once all warnings are fixed, no need to wait for React 19. It only notifies you of patterns that are incompatible with the React Compiler, but does not introduce anything incompatible.
tlabaj
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new React Compiler linter to the linting configuration and sets it to emit warnings where violations are detected. These warnings will need to be fixed and then turned into errors as a follow up (see #11138).
Closes #11137