perf(core): remove @floating-ui/dom dependency
#2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 788a567 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zeroedin
changed the title
zeroedin
changed the title
@floatingui/dom dependency
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "perf(core): remove `@floating-ui/dom` dependency"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zeroedin
changed the title
@floatingui/dom dependency@floating-ui/dom dependency
This comment has been minimized.
This comment has been minimized.
our config is hardcoded
Contributor
bennypowers
changed the title
@floating-ui/dom dependency@floating-ui/dom dependency
Contributor
Contributor
markcaron
approved these changes
Oct 23, 2025
Contributor
markcaron
left a comment
markcaron
left a comment
There was a problem hiding this comment.
PFE / Upstream part LGTM
Member
|
@adamjohnson merge and release this when you're satisfied it doesn't break rhds plznthx |
adamjohnson
approved these changes
Oct 24, 2025
Collaborator
adamjohnson
left a comment
adamjohnson
left a comment
There was a problem hiding this comment.
Tested PFE tooltip, popover, and dropdown, ✅
Ran a build, copied over and tested audio player and tooltip ✅
Library Gone, Trust Maintained
Collaborator
|
We can merge and release in Office Hours (or before if @bennypowers you're feeling it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is an attempt to static the implementation of
@floating-ui/dom, so we no longer have to update that dependency or serve it downstream. This implementation will eventually be replaced entirely with browser APIs in anchor positioning.@floating-ui/domdependency by way of AI copying its functionality into our own repo.pfe-core/core/functions.FloatingDomControllerto import from the new location.TODO
Testing Instructions
Notes to Reviewers
The copied API was completed with the assistance of Claude AI. Please give extra scrutiny to this code.