-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SourcesCard): Add support for external links #499
Conversation
Added new prop to handle whether link is external or not
9be98cb
to
f05b30d
Compare
Preview: https://chatbot-pr-chatbot-499.surge.sh A11y report: https://chatbot-pr-chatbot-499-a11y.surge.sh |
Looks great! Could you add this line to the existing example doc (bolding here just for visibility)
|
Should be all set @edonehoo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 This PR is included in version 2.2.0-prerelease.40 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added new prop to handle whether link is external or not. Went with link level to allow for greater level of control. (Sources level would make them all external or not.)
Docs: https://chatbot-pr-chatbot-499.surge.sh/patternfly-ai/chatbot/messages#messages-with-sources