Skip to content

bringing back state via lineage #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2017
Merged

bringing back state via lineage #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edcbeb1
Bugfix for patternType docs - Atoms docs were showing in Atoms/Forms …
EvanLovely Oct 16, 2017
4e3d78c
Bringing back state assigned via lineage
EvanLovely Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/PatternLab/PatternData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ public static function gather($options = array()) {
$patternObjects = iterator_to_array($patternObjects);
ksort($patternObjects);

foreach ($patternObjects as $name => $object) {
/**
* @var string $name
* @var \SplFileInfo $object
*/
foreach ($patternObjects as $name => $object) {

$ext = $object->getExtension();
$isDir = $object->isDir();
Expand Down Expand Up @@ -181,19 +185,17 @@ public static function gather($options = array()) {
$dispatcherInstance->dispatch("patternData.lineageHelperEnd",$event);


// `PatternStateHelper` is deprecated. It was for adding state to all patterns in the lineage of the pattern with state and that is no longer needed. Commenting out use and deprecating class in case there's a use I haven't figured out.

// dispatch that the pattern state helper is about to start
// $event = new PatternDataEvent($options);
// $dispatcherInstance->dispatch("patternData.patternStateHelperStart",$event);
$event = new PatternDataEvent($options);
$dispatcherInstance->dispatch("patternData.patternStateHelperStart",$event);

// using the lineage info update the pattern states on PatternData::$store
// $patternStateHelper = new PatternStateHelper();
// $patternStateHelper->run();
$patternStateHelper = new PatternStateHelper();
$patternStateHelper->run();

// dispatch that the pattern state helper is ended
// $event = new PatternDataEvent($options);
// $dispatcherInstance->dispatch("patternData.patternStateHelperEnd",$event);
$event = new PatternDataEvent($options);
$dispatcherInstance->dispatch("patternData.patternStateHelperEnd",$event);

// set-up code pattern paths
$ppdExporter = new PatternPathSrcExporter();
Expand Down
8 changes: 7 additions & 1 deletion src/PatternLab/PatternData/Exporters/PatternPartialsExporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,13 @@ public function run($type = "", $subtype = "") {

}

} else if (($patternStoreData["category"] == "pattern") && $canShow && (isset($patternStoreData["full"]) && ($type === $patternStoreData["full"] || $type === ""))) {
} else if (
($patternStoreData["category"] == "pattern")
&& $canShow
&& (isset($patternStoreData["full"])
&& ($type === $patternStoreData["full"] || $type === ""))
&& ($subtype === "")
) {
// This is for `patternType` docs. Given this structure:
// - _patterns/
// - atoms/
Expand Down
1 change: 0 additions & 1 deletion src/PatternLab/PatternData/Helpers/PatternStateHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
/**
* Class PatternStateHelper
* @package PatternLab\PatternData\Helpers
* @deprecated 3.0.0 It was for adding state to all patterns in the lineage of the pattern with state and that is no longer needed.
*/
class PatternStateHelper extends \PatternLab\PatternData\Helper {

Expand Down