Added threadpool for check version integrity #176
Conversation
Szczyrk
changed the base branch from
dev/v3.17.x.x
to
experimental/improved-download-unpacking-installation
| catch (Exception e) | ||
| { | ||
| DebugLogger.LogError(e.ToString()); | ||
| throw; |
There was a problem hiding this comment.
You shouldn't allow a thread to end up with an exception. A different solution is required here (like storing lastThreadException that is checked sometimes and rethrown is not null).
| bool _isCheckingSize; | ||
| private volatile bool _isCheckingHash; | ||
| private volatile bool _isCheckingSize; | ||
| private volatile int _space; |
There was a problem hiding this comment.
_currentThreadCount would be better there.
| tmp = _space; | ||
| } | ||
|
|
||
| if (tmp < 16) |
There was a problem hiding this comment.
Please introduce a constant MaxThreadCount instead of 16 here.
There was a problem hiding this comment.
Also, please consider semaphores - https://docs.microsoft.com/en-us/dotnet/api/system.threading.semaphore?view=net-5.0
| for (int i = 0; i < _versionSummary.Files.Length; i++) | ||
| files = new FileIntegrity[_versionSummary.Files.Length]; | ||
| int i = 0; | ||
| foreach (var file in _versionSummary.Files) |
There was a problem hiding this comment.
for can be reverted here, so only i needs to be passed to the thread (_versionSummary.Files is not modified anywhere so can be freely accessed from worker thread).
There was a problem hiding this comment.
@genail you suggested using foreach here because it works faster.
|
|
||
| for (int i = 0; i < _versionSummary.Files.Length; i++) | ||
| files = new FileIntegrity[_versionSummary.Files.Length]; | ||
| int i = 0; |
| } | ||
|
|
||
| var fileInThread = file; | ||
| var number = i; |
There was a problem hiding this comment.
Can be threadFileIndex.
No description provided.