Added thread pool for installation #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szczyrk
changed the base branch from
dev/v3.17.x.x
to
experimental/improved-download-unpacking-installation
witcher112
requested changes
Sep 21, 2021
| @@ -210,10 +224,46 @@ private void InstallFile(SourceFile sourceFile, CancellationToken cancellationTo | |||
| throw new FilePathTooLongException(string.Format("Cannot install file {0}, the destination path length has exceeded Windows path length limit (260).", destinationFilePath)); | |||
| } | |||
| #endif | |||
| FileOperations.Move(sourceFile.FullHashPath, destinationFilePath, cancellationToken); | |||
| _localMetaData.RegisterEntry(sourceFile.Name, _versionId, sourceFile.Size, isLastEntry); | |||
| while (true) | |||
There was a problem hiding this comment.
Please try to modify this code so it uses semaphores - https://docs.microsoft.com/en-us/dotnet/api/system.threading.semaphore?view=net-5.0
| } | ||
| } | ||
| }); | ||
| _localMetaData.RegisterEntry(sourceFile.Name, _versionId, sourceFile.Size, isLastEntry); |
There was a problem hiding this comment.
This needs to be done on thread as well since we cannot assume that thread succeeds and register the entry before it's indeed installed.
| @@ -143,7 +145,7 @@ public override void Execute(CancellationToken cancellationToken) | |||
| string nameHash; | |||
| if (mapHashExtractedFiles.TryGetHash(filePath, out nameHash)) | |||
| { | |||
| var sourceFile = new SourceFile(filePath, packageDir.Path, usedSuffix, nameHash, _versionContentSummary.Size); | |||
| var sourceFile = new SourceFile(filePath, packageDir.Path, usedSuffix, nameHash, _versionContentSummary.Files[i].Size); | |||
There was a problem hiding this comment.
Is this change related to the thread pool support?
If not please move it to another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.