-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: enable final link via C++ #389
base: master
Are you sure you want to change the base?
Conversation
It also links some files into a position where they are expected. No idea how to do this the right way(TM).
@@ -38,6 +38,11 @@ | |||
win_sysroot=`ls -1d ${WIN32SDK}/i?86-*mingw32* | head -n 1` | |||
win_cross=`ls -1 ${WIN32SDK}/bin/*mingw32*-gcc | head -n 1 | sed 's/gcc$//'` | |||
|
|||
test -f ${SYS_PREFIX}/include/WinSock2.h || ln -s $win_sysroot/include/winsock2.h ${SYS_PREFIX}/include/WinSock2.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you doing this instead of adding another -I$win_sysroot/include
in targets/win32/build-binary#L89? Also, does this filename case matter?
@@ -87,7 +87,7 @@ if [ `is_standalone_app` = "yes" ]; then | |||
else | |||
if [ `is_gui_app` = yes ]; then | |||
veval "$SYS_CC -I$SYS_PREFIX/include \ | |||
$cflag_additions -mwindows win32_microgl.c main.c icon.o -o $tgt \ | |||
$cflag_additions -mwindows -fpermissive win32_microgl.c main.c icon.o -o $tgt \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the -fpermissive
also only be applied when using a c++ compiler, as I thought this was only needed if you use non-conforming code?
Am Wed, 04 Nov 2020 00:44:39 -0800
schrieb Matthias Görges <[email protected]>:
@mgorges commented on this pull request.
> @@ -38,6 +38,11 @@
win_sysroot=`ls -1d ${WIN32SDK}/i?86-*mingw32* | head -n 1`
win_cross=`ls -1 ${WIN32SDK}/bin/*mingw32*-gcc | head -n 1 | sed
's/gcc$//'`
+test -f ${SYS_PREFIX}/include/WinSock2.h || ln -s
$win_sysroot/include/winsock2.h ${SYS_PREFIX}/include/WinSock2.h
Why are you doing this instead of adding another
`-I$win_sysroot/include` in targets/win32/build-binary#L89?
because I did not find the right spot to do such a thing
at the other hand: I'd rather not need such a shitty hack at all
Also, does this filename case matter?
That's been the issue behind: I cross-compile for Win32 under Linux.
That's when it failed to work.
|
Am Wed, 04 Nov 2020 00:45:55 -0800
schrieb Matthias Görges <[email protected]>:
@mgorges commented on this pull request.
> @@ -87,7 +87,7 @@ if [ `is_standalone_app` = "yes" ]; then
else
if [ `is_gui_app` = yes ]; then
veval "$SYS_CC -I$SYS_PREFIX/include \
- $cflag_additions -mwindows win32_microgl.c main.c icon.o -o
$tgt \
+ $cflag_additions -mwindows -fpermissive win32_microgl.c main.c
icon.o -o $tgt \
Shouldn't the `-fpermissive` also only be applied when using a c++
compiler, as I thought this was only needed if you use non-conforming
code?
Likely it should. Again just a bad work around the actual issue: maybe
someone knows how to fix the offending lines in the source code in a
way compatible with both dialects.
|
It also links some files into a position where they are expected.
No idea how to do this the right way(TM).