Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: enable final link via C++ #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0-8-15
Copy link
Contributor

@0-8-15 0-8-15 commented Nov 2, 2020

It also links some files into a position where they are expected.

No idea how to do this the right way(TM).

It also links some files into a position where they are expected.

No idea how to do this the right way(TM).
@@ -38,6 +38,11 @@
win_sysroot=`ls -1d ${WIN32SDK}/i?86-*mingw32* | head -n 1`
win_cross=`ls -1 ${WIN32SDK}/bin/*mingw32*-gcc | head -n 1 | sed 's/gcc$//'`

test -f ${SYS_PREFIX}/include/WinSock2.h || ln -s $win_sysroot/include/winsock2.h ${SYS_PREFIX}/include/WinSock2.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you doing this instead of adding another -I$win_sysroot/include in targets/win32/build-binary#L89? Also, does this filename case matter?

@@ -87,7 +87,7 @@ if [ `is_standalone_app` = "yes" ]; then
else
if [ `is_gui_app` = yes ]; then
veval "$SYS_CC -I$SYS_PREFIX/include \
$cflag_additions -mwindows win32_microgl.c main.c icon.o -o $tgt \
$cflag_additions -mwindows -fpermissive win32_microgl.c main.c icon.o -o $tgt \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the -fpermissive also only be applied when using a c++ compiler, as I thought this was only needed if you use non-conforming code?

@0-8-15
Copy link
Contributor Author

0-8-15 commented Nov 5, 2020 via email

@0-8-15
Copy link
Contributor Author

0-8-15 commented Nov 5, 2020 via email

@gassechen

This comment has been minimized.

@mgorges

This comment has been minimized.

@gassechen

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants