Skip to content

chore: add Docker build to tag release workflow #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

nitisht
Copy link
Member

@nitisht nitisht commented Jun 5, 2025

Fixes #1331

Summary by CodeRabbit

  • Chores
    • Automated building and publishing of multi-platform Docker images to Docker Hub as part of the release workflow.

Copy link
Contributor

coderabbitai bot commented Jun 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new job named push-docker-image was added to the GitHub Actions release workflow. This job builds and pushes a multi-platform Docker image (supporting both linux/amd64 and linux/arm64) to Docker Hub, using credentials from repository secrets and tagging the image with the current Git reference name.

Changes

File(s) Change Summary
.github/workflows/release.yml Added push-docker-image job to build and push multi-architecture Docker images to Docker Hub on release.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Docker Hub

    GitHub Actions->>GitHub Actions: Checkout repository
    GitHub Actions->>GitHub Actions: Setup QEMU for multi-arch
    GitHub Actions->>GitHub Actions: Setup Docker Buildx
    GitHub Actions->>Docker Hub: Login using secrets
    GitHub Actions->>GitHub Actions: Extract Docker image metadata
    GitHub Actions->>Docker Hub: Build & push multi-arch Docker image (amd64, arm64)
Loading

Assessment against linked issues

Objective Addressed Explanation
Support multi-architecture (amd64 and arm64) Docker images in release workflow (#1331)

Poem

In the warren where workflows hop and run,
Now Docker images build for everyone!
Arm and AMD64, both platforms in the stew,
The bunnies rejoice, “Multi-arch, who knew?”
With a push and a tag, the carrots align—
Shipping for all, in Docker we shine! 🐇🐳


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eeea985 and 2c9e3c0.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nitisht
Copy link
Member Author

nitisht commented Jun 5, 2025

I have read the CLA Document and I hereby sign the CLA

@nitisht
Copy link
Member Author

nitisht commented Jun 5, 2025

recheck

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
.github/workflows/release.yml (2)

211-216: Optional: leverage metadata-action outputs or remove unused step
You're extracting metadata with docker/metadata-action@v5 (id: meta) but not consuming its outputs. Consider:

  • Using ${{ steps.meta.outputs.tags }} (and .labels) in the build step for dynamic tagging.
  • Removing the metadata-action step if you don't need those outputs.

191-193: Optional: add needs for deterministic job ordering
Without a needs key, push-docker-image may run in parallel with other jobs. If image publishing should wait for all build and checksum jobs, add:

needs: [build-linux, build-windows, build-mac, create-checksum]
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad12b8d and eeea985.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/release.yml

195-195: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: coverage
🔇 Additional comments (1)
.github/workflows/release.yml (1)

195-195: False positive: checkout action version
The actionlint warning about actions/checkout@v3 being too old is a false positive—v3 is the current version and fully supported on GitHub-hosted runners.

🧰 Tools
🪛 actionlint (1.7.7)

195-195: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

@nitisht
Copy link
Member Author

nitisht commented Jun 5, 2025

Merging because no code changes.

@nitisht nitisht merged commit 2cd3381 into parseablehq:main Jun 5, 2025
12 of 14 checks passed
@nitisht nitisht deleted the release-docker branch June 5, 2025 06:24
@nitisht nitisht mentioned this pull request Jun 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container image in Helm chart only supports AMD64 architecture
1 participant