chore: add Docker build to tag release workflow #1336
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA new job named Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Docker Hub
GitHub Actions->>GitHub Actions: Checkout repository
GitHub Actions->>GitHub Actions: Setup QEMU for multi-arch
GitHub Actions->>GitHub Actions: Setup Docker Buildx
GitHub Actions->>Docker Hub: Login using secrets
GitHub Actions->>GitHub Actions: Extract Docker image metadata
GitHub Actions->>Docker Hub: Build & push multi-arch Docker image (amd64, arm64)
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/release.yml (2)
211-216: Optional: leverage metadata-action outputs or remove unused step
You're extracting metadata withdocker/metadata-action@v5(id: meta) but not consuming its outputs. Consider:
- Using
${{ steps.meta.outputs.tags }}(and.labels) in the build step for dynamic tagging.- Removing the metadata-action step if you don't need those outputs.
191-193: Optional: addneedsfor deterministic job ordering
Without aneedskey,push-docker-imagemay run in parallel with other jobs. If image publishing should wait for all build and checksum jobs, add:needs: [build-linux, build-windows, build-mac, create-checksum]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/release.yml
195-195: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: coverage
🔇 Additional comments (1)
.github/workflows/release.yml (1)
195-195: False positive: checkout action version
The actionlint warning aboutactions/checkout@v3being too old is a false positive—v3 is the current version and fully supported on GitHub-hosted runners.🧰 Tools
🪛 actionlint (1.7.7)
195-195: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
|
Merging because no code changes. |
Fixes #1331
Summary by CodeRabbit