Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get_stats merge and simplify #1150

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 30, 2025

Fixes #XXXX.

Description

  • Use serde and Query to abstract away param extraction
  • Merge get_stats from logstream.rs(used in both ingestor and standalone) and query_logstream.rs(used in querier)
  • Organize imports in affected files

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh changed the title refactor: simplify query param extraction refactor: simplify query param extraction and merge get_stats Jan 31, 2025
@de-sh de-sh changed the title refactor: simplify query param extraction and merge get_stats refactor: get_stats merge and simplify Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant