Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: DRY object_storage #1147

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

refactor: DRY object_storage #1147

wants to merge 10 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 29, 2025

Fixes #XXXX.

Description

  • Ensure parts of object storage aren't unnecessarily copied and code is trimmed off

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh marked this pull request as draft January 29, 2025 21:59
@de-sh de-sh marked this pull request as ready for review February 1, 2025 09:55
parmesant
parmesant approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@parmesant parmesant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmesant parmesant parmesant approved these changes

@nikhilsinhaparseable nikhilsinhaparseable Awaiting requested review from nikhilsinhaparseable

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@de-sh @parmesant