fix: oidc connection #1117
Merged
fix: oidc connection #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed requires and group from oidc related args we are anyways checking in the `openid()` if all three exists then set OpenidConfig, else None
Pull Request Test Coverage Report for Build 12849996633Details
💛 - Coveralls |
|
We are silently not enabling oidc when either of the configs are not present, this is wrong imo, have opened a PR that fixes this on your fork: nikhilsinhaparseable#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed requires and group from oidc related args
we are anyways checking in the
openid()if all three existsthen set OpenidConfig, else None